https://www.dynamic-designs.us
http://www.dynamic-designs.us/d-dforum/

Item Naming bugfix
http://www.dynamic-designs.us/d-dforum/viewtopic.php?f=16&t=1180		 Page 1 of 1
Author:  motke [ Wed May 21, 2025 3:21 pm ]
Post subject:  Item Naming bugfix
The Item naming bug in version 0.99 translation happens not only in the Bonus Dungeon, but also in the Main Dungeon, and can sometimes wipe out player's SRAM file, depending on the layout of corrupted memory areas.
You can 100% reliably reproduce this game-crashing bug by giving any name to any unidentified item and then, without completely leaving the menus, going back to any of the four rubrics of the Main Menu, such as the Item menu again or Grab. Closing the menus upon renaming an item, on the other hand, prevents the crash. At least, this is the situation in the Main Dungeon.
This bug is caused by a memory buffer overrun introduced with the translation related to the changes in this Name menu. I've created this stopgap patch that prevents the crash and seems to work fine. I've spent several hours playtesting it, but so far only in the Main Dungeon. Further testing would be welcome, or I would appreciate if someone could upload an SRM file with the Bonus Dungeon unlocked. Maybe this patch will be on romhacking.net one day.
This patch should be applied to the unheadered translated ROM, even though the English translation itself required a headered one.
CRC32 of the unheadered translated ROM is 0x96064895, and the CRC32 of the resulting ROM is 0xEEAFB152.
Here's a list of changed bytes, and I'm also attaching an IPS file:

Code:
fc /b torneko_099.sfc torneko_mypatch.sfc

0001E5E2: 0D 20
0001E5E3: 39 F0
0001E5E4: DC FF
0001FFF0: FF 0D
0001FFF1: FF 39
0001FFF2: FF DC
0001FFF3: FF 29
0001FFF4: FF 03
0001FFF5: FF 60


There is also a separate Item Naming bug present in the Japanese original. If you name any item at a time very close to the end of the period between the second and the final earthquake AND then "End" the game session before the final earthquake, your SRAM will be corrupted upon reboot. Renaming actions are recorded in the SRAM on each turn for the Replay feature, and doing renaming not long before the final earthquake causes a buffer overrun in the SRAM. You just have to be mindful of this bug.

Attachments:
tornekopatch.zip [196 Bytes]
Downloaded 96 times
Author:  taskforce [ Thu May 29, 2025 6:44 pm ]
Post subject:  Re: Item Naming bugfix
Nice Job, if I get time I'll look into putting this into the patch and releasing a 0.991 or something as long as you are ok with that. I'll be sure to give you credit in the readme. Thanks for the actual bytes of the fix.
Author:  motke [ Fri May 30, 2025 5:25 pm ]
Post subject:  Re: Item Naming bugfix
Sorry, but while waiting for my post to be approved here, which took more than a week I think, I released the addendum patch on romhacking.net and updated it. This v0.2 update fixes another issue stemming from the same root cause, that is, once you leave the renaming menu and go back to the Main In-game Menu, you could previously move the white cursor above and below this Main In-game Menu's box, like you could go below the Grab option. I'm attaching the IPS here too. CRC32 of the patched file should now be: A2946CD0
But yeah, feel free to release a translation patch update, if you think this limited amount of playtesting that only transpired in the Main Dungeon is OK. If it's updated at romhacking.net, I will remove my addendum patch there.

Attachments:
tornekopatch2.zip [206 Bytes]
Downloaded 101 times
Author:  taskforce [ Fri May 30, 2025 8:16 pm ]
Post subject:  Re: Item Naming bugfix
Yeah, sorry, I stay a bit busy and just don't get by here as much as I should. It can literally take me a few weeks sometimes to come around. And unfortunately, the rest of the team is retired or just never makes it around at all. I'll try to remember to get here more often but I can't make promises.
Page 1 of 1 All times are UTC [ DST ]
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
http://www.phpbb.com/